Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04c943e61a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR updates transfer logic to better handle legacy well/sensor fields by normalizing completion dates, improving status-code handling, and adding a set of hard-coded recording-interval overrides, with accompanying test coverage for the date normalization.
Changes:
- Normalize
CompletionDatevalues todateobjects before validating/creatingCreateWell. - Strip/validate well status codes during lexicon mapping and capture unknown codes as transfer errors.
- Add static recording-interval overrides for specific PointIDs and introduce tests for the completion-date normalization.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| transfers/well_transfer.py | Adds completion-date normalization and improves Status lexicon mapping/error capture. |
| transfers/util.py | Introduces static recording-interval overrides used by SensorParameterEstimator. |
| tests/test_transfer_legacy_dates.py | Adds unit tests validating completion-date normalization behavior. |
| core/lexicon.json | Adds a new status_value term (“Open (unequipped)”) and adjusts formatting. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…pes and improve error reporting
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
transfers/well_transfer.py:751
- In the parallel transfer path, calling
self._capture_error(...)here appends toself.errors(shared, not thread-safe) and those errors will be lost becausetransfer_parallel()later overwritesself.errorswith the mergedall_errorslist. Capture this unknown-status case into the per-batchbatch_errorslist (or a thread-safe aggregator) instead of using_capture_errordirectly inside worker threads.
)
)
for code, monitoring_frequency in NMA_MONITORING_FREQUENCY.items():
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?